Fix Recent Applications sorting in Kicker and Dashboard.
ClosedPublic

Authored by hein on Fri, Jun 1, 5:01 PM.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Fri, Jun 1, 5:01 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Jun 1, 5:01 PM
hein requested review of this revision.Fri, Jun 1, 5:01 PM
davidedmundson accepted this revision.Fri, Jun 1, 5:28 PM
davidedmundson added a subscriber: davidedmundson.

Is that really the only way to disable a sort :/

This revision is now accepted and ready to land.Fri, Jun 1, 5:28 PM
hein added a comment.Fri, Jun 1, 6:21 PM

It almost seems so :(. I think the only alternative might be overriding sort() and making it noop, if you'd prefer that.

The code was written under the assumption that QSFPM would never start sorting unless sort() was called, but it was sorting anyway,so something may be calling it (not me). I don't trust that nothing will randomly poke things and cause a sort, so it's better to be safe and control what sorting will do.

This revision was automatically updated to reflect the committed changes.