Don't scale resolution dependent cursor size twice
ClosedPublic

Authored by davidedmundson on Fri, Jun 1, 12:58 PM.

Details

Summary

If the env var is 0 we calculate the cursor size based on the
physical resolution.

The size is multiplied by the output scale.

Either would make sense, together does not and reuslts in kwin
having massive cursors.

This patch is for 5.13.

For master I intend to kill this concept of "resolution dependent size"
on the KCM. We then should do wayland scaling on cursors properly no matter
what size the user selects which will work better for when we have
multiple screens.

I have a WIP patch pending for the latter, but it's too big for here.
It still involves deleting this code.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Fri, Jun 1, 12:58 PM
Restricted Application added a project: KWin. · View Herald TranscriptFri, Jun 1, 12:58 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Fri, Jun 1, 12:58 PM
romangg added a subscriber: romangg.Fri, Jun 1, 2:30 PM

If the scale changes now for the first screen, it wouldn't reload the theme, right? I.e. remove the multiplication but leave the connect.

If the scale changes now for the first screen, it wouldn't reload the theme, right? I.e. remove the multiplication but leave the connect.

scale would be the wrong thing to follow in that case
I can change it to pixelSizeChanged and keep it.

If the scale changes now for the first screen, it wouldn't reload the theme, right? I.e. remove the multiplication but leave the connect.

scale would be the wrong thing to follow in that case
I can change it to pixelSizeChanged and keep it.

Ok, let's do it like this then.

romangg accepted this revision.Fri, Jun 1, 3:14 PM
This revision is now accepted and ready to land.Fri, Jun 1, 3:14 PM
This revision was automatically updated to reflect the committed changes.