Differential D13251

Remove superfluous code for empty KIPI toolbar button
ClosedPublic
Actions

Authored by rkflx on May 31 2018, 7:11 PM.

Details

Reviewers
faridb
Group Reviewers
Gwenview
Commits
R260:ed455f744def: Remove superfluous code for empty KIPI toolbar button
Summary

In case there are no KIPI plugins installed, Gwenview needs to show the
No Plugin Found entry instead.

Since the corresponding action is already added to mExportActionList
in KIPIInterface::pluginActions, we don't need to add it again.

Test Plan

Uninstall Discover and kipi-plugins, check that KIPI toolbar
button still shows No Plugin Found.

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rkflx requested review of this revision.May 31 2018, 7:11 PM
rkflx created this revision.
rkflx updated this revision to Diff 35388.Jun 2 2018, 6:19 AM

Rebase

faridb accepted this revision.Jun 2 2018, 2:10 PM
This revision is now accepted and ready to land.Jun 2 2018, 2:10 PM
Closed by commit R260:ed455f744def: Remove superfluous code for empty KIPI toolbar button (authored by rkflx). · Explain WhyJun 2 2018, 6:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapp/kipiexportaction.cpp (6 lines)

Diff 35419

View Options

app/kipiexportaction.cpp

Loading...