Show it as a full button instead of a tool button.
Use the icon color as the button color.
Details
Details
- Reviewers
mart ngraham - Group Reviewers
Kirigami - Commits
- R169:cf62d95943e8: Show action.main more prominently on the ToolBarApplicationHeader
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Love it! Two issues that I can see:
- In this example, the text really needs to be white; it doesn't show up well against the dark green background. If the color is programmatically determined, we may need some fancy logic to choose the button's text color to ensure that it's visible enough. For that matter, the icon doesn't show up very well either...
- The button has no right padding, and touches the window edge ( A Discover issue?)
Comment Actions
Yeah... thought so too. If people are not against the idea it's something to spend time on. I'm afraid it could look weird though...
- The button has no right padding, and touches the window edge ( A Discover issue?)
No, still in kirigami, it's just that with a non-flat button we don't take into account the padding within the button as a margin. We can add a margin.
src/controls/ToolBarApplicationHeader.qml | ||
---|---|---|
105 | can just assign flat: false instead of adding a new property in actiontoolbutton? |