In LatexEntry::updateEntry path to esp file is constructed invalid. This commit fix it. During debuging, it was found, that EpsRenderer don't check, that input is valid, at all. So, the commit also add checking, that input file is valid eps file, and warning message printing, if it is not true.
BUG: 330834
FIXED-IN: 18.04.2
| No Linters Available |
| No Unit Test Coverage |
The fix is ok in general. Though, I'd prefer to have the already rendered eps-file as a member of LabelEntry object so it is always available and can be directly used for rendering, for printing and for saving without the need to involve the latex render every time again and again.
If I see it correctly, when a project is saved only LatexEntry::latexCode() is saved. Saving the string only requires re-running latex every time the project file is opened. Also, on systems without latex installation we'll fail to show such a project with worksheets having latex entries. It would be better to save the rendered images in the project file - either as base64 encoded image byte array directly in the xml file (similar to LabPlot's TextLabel https://phabricator.kde.org/source/labplot/browse/master/src/backend/worksheet/TextLabel.cpp;0adab041ea9156243a5bde10f79bc96daeff86d8$691) or as a png or eps file stored in the zip-archive similar to how this is already done in Cantor for rendered plots.
So, we can submit this change now to fix the bug 330834 but I think we should re-factor this a bit later to address the issues mentioned above.
| src/epsrenderer.cpp | ||
|---|---|---|
| 107 | why not to check the URL first with QUrl::isValid() either here or in LatexEntry::updateEntry() where? | |
| src/latexentry.cpp | ||
| 219 | this can be const reference. | |
| src/latexentry.cpp | ||
|---|---|---|
| 219 | Ok | |
| src/epsrenderer.cpp | ||
|---|---|---|
| 107 | QUrl::isValid() checks, that url is valid. But we also need check, that this url is a url of valid eps file. And spectre_document_is_eps does both verifications (but maybe I mistaken) | |
| src/latexentry.cpp | ||
|---|---|---|
| 219 | const QUrl& url | |