[lookandfeel/lockscreen] Hide cursor on login controls fade out
Changes PlannedPublic

Authored by romangg on May 29 2018, 8:07 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

With the new lockscreen fade out effect the mouse cursor was still shown
while the login controls were hidden.

Use the new property in the greeter app to hide the cursor while the login
controls are hidden to have a cleaner look.

Test Plan

Manually

Diff Detail

Repository
R120 Plasma Workspace
Branch
lockscreenHideCursor
Lint
No Linters Available
Unit
No Unit Test Coverage
romangg created this revision.May 29 2018, 8:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 29 2018, 8:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.May 29 2018, 8:07 PM
romangg retitled this revision from [lookandfeel/lockscreen] Hide cursor on fade out to [lookandfeel/lockscreen] Hide cursor on login controls fade out.May 29 2018, 8:10 PM
broulik added inline comments.
lookandfeel/contents/lockscreen/LockScreenUi.qml
72

How about

cursorShape: uiVisible ? Qt.ArrowCursor : Qt.BlankCursor
romangg added inline comments.May 29 2018, 8:46 PM
lookandfeel/contents/lockscreen/LockScreenUi.qml
72

The problem was that I first had to move the mouse to enter the MouseArea. I.e. when the Screenlocker is activated by timer the cursor is visible until first time the mouse is moved and then the fade out timer triggers afterwards.

mart added a subscriber: mart.May 30 2018, 8:11 AM
mart added inline comments.
lookandfeel/contents/lockscreen/LockScreenUi.qml
72

shouldn't that mousearea cover the whole area? if cursorshape doesn't work for a thing that appears under the cursor that's definitely a mousearea bug

romangg added inline comments.May 30 2018, 9:43 AM
lookandfeel/contents/lockscreen/LockScreenUi.qml
72

You are right, that it should cover the whole area, if it could be used. I added a comment to D13206 with a link to the Qt bug why it can't be used.

In the multiscreen case you have two LockScreenUi files altering the same single property, does it work?

romangg planned changes to this revision.May 30 2018, 10:22 AM

In the multiscreen case you have two LockScreenUi files altering the same single property, does it work?

You are right, there is the problem that it hides the cursor if the second screen hides the ui while the cursor is on the first one with visible ui.

But the overall mechanism doesn't seem to work well for multi-screen. The ui fades sometimes without fade out timer grace period. I can't type my password in the second screen.

Also imo the ui should show and fade out on all screens synchronized.

Will look into this when I find time.