Differential D13186

Use HiddenStatus when keyboard indicator is inactive
Needs ReviewPublic
Actions

Authored by arojas on May 29 2018, 6:10 AM.

Details

Reviewers
apol
Summary

This way it doesn't take space in the systray popup or in the panel when inactive, which is not useful since the applet is not interactive.

Test Plan

Applet disappears from panel and from systray popup when inactive instead of taking space, appears again when active.

Diff Detail

Repository
R114 Plasma Addons
Lint
Lint Skipped
Unit
Unit Tests Skipped
arojas created this revision.May 29 2018, 6:10 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 29 2018, 6:10 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
arojas requested review of this revision.May 29 2018, 6:10 AM
broulik added a subscriber: broulik.EditedMay 29 2018, 6:36 AM

+1

Fine in principle but there's currently no way to access an applet's settings if it is hidden, so when you disable e.g. Caps Lock for Num Lock and don't have that, it will become inaccessible (until you remove and re-add?) :/

apol added a comment.May 29 2018, 10:40 AM

How would one configure it if it's hidden?

arojas added a comment.May 29 2018, 10:08 PM

Right, I guess if someone disables everything on the config there's no way to reenable them in systray-embedded mode (well, removing and readding the applet will reset the config, but that's not obvoius)

mart added a subscriber: mart.Nov 12 2018, 10:51 AM

maybe should be added a way to configure the applets from the entries tab of the config dialog as well?

Revision Contents
Changeset List

Diff 35074

View Options

applets/keyboardindicator/contents/ui/main.qml

Loading...