Add 404 page and update search javascript file to block it
ClosedPublic

Authored by scottpetrovic on May 29 2018, 1:54 AM.

Details

Reviewers
woltherav
Group Reviewers
Krita: Manual
Summary

This patch adds a 404 page to every language. Also it makes sure 404 pages do not show in the search results

Test Plan

Tested the search results.
Tested the page individually. It will probably need some further text changes.

Diff Detail

Repository
R1012 Krita.org Documentation Website
Lint
Lint Skipped
Unit
Unit Tests Skipped
scottpetrovic requested review of this revision.May 29 2018, 1:54 AM
scottpetrovic created this revision.
woltherav requested changes to this revision.May 29 2018, 9:33 AM

I have the feeling this is somehow the German version of the file?

The 1.7.2 version one in the sphinx repositories:
https://github.com/sphinx-doc/sphinx/blob/v1.7.2/sphinx/themes/basic/static/searchtools.js_t

Those instead appear at
https://github.com/sphinx-doc/sphinx/blob/v1.7.2/sphinx/search/de.py

I have the feeling this is a precompiled file somehow...?

Could you try figuring out what is up with that, otherwise this gives me the feeling it will break language support.

This revision now requires changes to proceed.May 29 2018, 9:33 AM

Yes. Good catch. I updated the javascript file with what is in the "base" theme found in the sphinx directory. I did a "make html" and it seems to be swapping out the variables with the language

Restricted Application added a project: Krita: Manual. · View Herald TranscriptMay 29 2018, 3:47 PM
Restricted Application added a reviewer: Krita: Manual. · View Herald Transcript
woltherav accepted this revision.May 29 2018, 4:02 PM

Alrighty, try pushing this to master :)

This revision is now accepted and ready to land.May 29 2018, 4:02 PM
scottpetrovic closed this revision.May 29 2018, 5:48 PM

pushed. closing

Deevad added a subscriber: Deevad.May 31 2018, 12:10 PM

Hi, I'm cross referencing it here:
krita (Documentation) filed by info@davidrevoy.com [NOR - crash]: New documentation: Old index page now return missing page
https://bugs.kde.org/394892