Differential D13156

[effects/maximize] Use more verbose name for WindowForceBlurRole instead of an integer
ClosedPublic
Actions

Authored by zzag on May 27 2018, 4:54 PM.

Details

Reviewers
mart
Group Reviewers
KWin
Commits
R108:42dc3e4cd560: [effects/maximize] Use more verbose name for WindowForceBlurRole instead of an…
Test Plan
  • Maximized Konsole with enabled blur
  • Everything works as expected

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.May 27 2018, 4:54 PM
Restricted Application added a project: KWin. · View Herald TranscriptMay 27 2018, 4:54 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.May 27 2018, 4:54 PM
zzag added a comment.May 27 2018, 5:00 PM

Is there a point to store previous state of the force blur role? Also, it looks like if there are several maximize animations, previous state of the blur force role will shared among them.

mart accepted this revision.May 30 2018, 8:42 AM
This revision is now accepted and ready to land.May 30 2018, 8:42 AM
Closed by commit R108:42dc3e4cd560: [effects/maximize] Use more verbose name for WindowForceBlurRole instead of an… (authored by zzag). · Explain WhyMay 31 2018, 9:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35239

View Options

effects/maximize/package/contents/code/maximize.js

Loading...