Kig bug 394676
ClosedPublic

Authored by bourquin on May 26 2018, 9:48 PM.

Details

Reviewers
narvaez
paolini
Summary

Fix bug 394676

Diff Detail

Repository
R331 Kig
Lint
Lint Skipped
Unit
Unit Tests Skipped
bourquin created this revision.May 26 2018, 9:48 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMay 26 2018, 9:48 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
bourquin requested review of this revision.May 26 2018, 9:48 PM

This patch is on top of the golden ratio point patch.

This patch is on top of the golden ratio point patch.

Your patch works for me. This also incorporates the solution for https://bugs.kde.org/show_bug.cgi?id=394676
I don't know what is the right course of action in this situation

bourquin updated this revision to Diff 34944.May 26 2018, 11:57 PM
bourquin edited the summary of this revision. (Show Details)

Update for Segment and Ray code.

Can we merge this or what should be done next here?

I think we should wait for David Narvaez to decide what to do

paolini accepted this revision.Jun 1 2018, 3:31 PM

Now that the goldenpoint got merged in master, we should also push this bug patch (in master). I can take care of that.
perhaps a bug should also be merged into other branches of kig?

This revision is now accepted and ready to land.Jun 1 2018, 3:31 PM
paolini closed this revision.Jun 1 2018, 3:39 PM

pushed patch to master