Differential D13128

Make sure ungrab keyboard request is processed before emitting shortcut
ClosedPublic
Actions

Authored by sontolbonggol on May 26 2018, 4:00 AM.

Details

Reviewers
mck182
davidedmundson
Group Reviewers
Frameworks
Plasma
Commits
R268:706730f9d7a3: Make sure ungrab keyboard request is processed before emitting shortcut
Summary

In some rare cases, the ungrab keyboard request is processed later than
the action of the key shortcut. This can make the application that try
to grab the keyboard (e.g. in kwin) fail to do so. The solution is to
use ungrab_keyboard_checked() and xcb_request_check() before emitting
the shortcut signal.

BUG: 394689

Diff Detail

Repository
R268 KGlobalAccel
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sontolbonggol created this revision.May 26 2018, 4:00 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 26 2018, 4:00 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
sontolbonggol requested review of this revision.May 26 2018, 4:00 AM
sontolbonggol edited the summary of this revision. (Show Details)May 26 2018, 4:08 AM
fvogt added a subscriber: fvogt.May 29 2018, 8:37 AM
This revision is now accepted and ready to land.May 30 2018, 11:22 AM
fvogt added a comment.May 30 2018, 1:21 PM

@sontolbonggol Do you have access for pushing this or do you want someone else to do it?

sontolbonggol added a comment.May 30 2018, 1:31 PM

@fvogt I don't have push access. Will appreciate if someone does it for me. Thanks!

elvisangelaccio added a subscriber: elvisangelaccio.Jun 1 2018, 8:51 PM

@sontolbonggol What's the email address we should use for the git commit?

sontolbonggol added a comment.Jun 1 2018, 8:53 PM

@elvisangelaccio you can put my email sonbonggol@gmail.com. Thanks!

Closed by commit R268:706730f9d7a3: Make sure ungrab keyboard request is processed before emitting shortcut (authored by sontolbonggol, committed by elvisangelaccio). · Explain WhyJun 1 2018, 9:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35374

View Options

src/runtime/plugins/xcb/kglobalaccel_x11.cpp

Loading...