Adds a second line of text under icon/doc icons for more clarity.
Will stop at two lines; if text continues, it will be elided.
BUG: 362986
Adds a second line of text under icon/doc icons for more clarity.
Will stop at two lines; if text continues, it will be elided.
BUG: 362986
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
applets/kicker/package/contents/ui/ItemGridDelegate.qml | ||
---|---|---|
98 | Note: will wrap at an arbitrary point if there's no natural break. Happens with long filenames under "Recent Documents" sometimes. Otherwise, wraps at word breaks. |
Yep, this is exactly how I'd have done it, too.
Since this fixes https://bugs.kde.org/show_bug.cgi?id=362986, let's add BUG: 362986 at the bottom of the Summary (if you do it with the web interface, don't forget to do arc amend to pull the changes down to your local copy).
applets/kicker/package/contents/ui/ItemGridDelegate.qml | ||
---|---|---|
98 | Trailing space. |
Hmm, I might have waited for @hein's review too... One thing I'm myself just now coming to understand is that it's often a good idea to wait for more than just one reviewer to offer their view.
Oh. I see. The Phab emails say "now ready to land", so I did what the machine told me to. But I clearly see your point.
Hopefully he will be okay with it. If not, I'm more than willing to roll it back and make any further changes.
I'm fine with this, but yes, in the future it's a good idea to wait for maintainer review, or e.g. one VDG and one "code monkey" review - we do a bad job communicating who "needs" to approve though so it's not really on you, and I'm OK with erring on the side of work proceeding. Worst case, things don't work out OK and get reverted (say, temporarily).