Differential D13103

[Look and Feel KCM] Make GHNS dialog modal
ClosedPublic
Actions

Authored by broulik on May 25 2018, 8:03 AM.

Details

Reviewers
mart
davidedmundson
Group Reviewers
Plasma
Commits
R119:ea5199a75187: [Look and Feel KCM] Make GHNS dialog modal
Summary

Makes it consistent with the other KCMs.

Test Plan

Code Copied from desktop theme KCM

  • GHNS dialog was modal to System Settings now
  • Downloading lnf packages still works

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 25 2018, 8:03 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 25 2018, 8:03 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 25 2018, 8:03 AM
davidedmundson accepted this revision.May 25 2018, 9:18 AM
This revision is now accepted and ready to land.May 25 2018, 9:18 AM
Closed by commit R119:ea5199a75187: [Look and Feel KCM] Make GHNS dialog modal (authored by broulik). · Explain WhyMay 25 2018, 9:25 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 34848

View Options

kcms/lookandfeel/kcm.h

Loading...
View Options

kcms/lookandfeel/kcm.cpp

Loading...
View Options

kcms/lookandfeel/package/contents/ui/main.qml

Loading...