Allow whitelisted cookies to be kept
ClosedPublic

Authored by tuomisto on May 24 2018, 4:28 PM.

Details

Summary

Added a new configurable option to keep whitelisted cookies
from being deleted when deleteCookiesOnClose is true

Diff Detail

Repository
R875 Falkon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tuomisto created this revision.May 24 2018, 4:28 PM
Restricted Application added a project: Falkon. · View Herald TranscriptMay 24 2018, 4:28 PM
Restricted Application added a subscriber: falkon. · View Herald Transcript
tuomisto requested review of this revision.May 24 2018, 4:28 PM
drosca requested changes to this revision.May 24 2018, 5:08 PM
drosca added a subscriber: drosca.

I think it should keep whitelisted cookies every time (it worked like that in QtWebKit version), so it's not needed to make it configurable.

src/lib/cookies/cookiejar.cpp
88

for (const QNetworkCookie &cookie : qAsConst(m_cookies))

This revision now requires changes to proceed.May 24 2018, 5:08 PM
tuomisto updated this revision to Diff 34834.May 24 2018, 6:11 PM
  • Remove configurability of whitelisted cookie removal

Whitelisted cookies remain in storage by default

drosca accepted this revision.May 24 2018, 7:05 PM
This revision is now accepted and ready to land.May 24 2018, 7:05 PM
This revision was automatically updated to reflect the committed changes.