Shortcut
ClosedPublic

Authored by hrouis on Apr 3 2016, 5:30 PM.

Details

Reviewers
mlaurent
bensi
Summary

Shortcut for show and hide the search bar

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
hrouis updated this revision to Diff 3109.Apr 3 2016, 5:30 PM
hrouis retitled this revision from to Shortcut .
hrouis updated this object.
hrouis edited the test plan for this revision. (Show Details)
hrouis added reviewers: mlaurent, bensi.
hrouis added a project: KDE PIM: KMail.
mlaurent added inline comments.Apr 4 2016, 6:19 AM
kmail/kmmainwidget.cpp
3320

CTRL+I ?

hrouis added a comment.Apr 4 2016, 8:34 PM

CTRL+I is the shortcut to show and hide the search bar .

bensi edited edge metadata.Apr 4 2016, 8:39 PM

i guess the question is "why ctrl+i ?"

hrouis added a comment.Apr 4 2016, 8:56 PM

Because escape is already assigned to another action so i chose CTRL+I

mlaurent edited edge metadata.Apr 7 2016, 6:49 AM

Ok why not but still why CTRL+I ? It will show search no ?
By default CTRL+I is for italic in editor mode.

By default a shortcut should logical with associate action.

So it is not necessary to use a shortcut to view and hidden de search bar?

I didn't say that it's not necessary to have a shortcut, but it's a problem to use not intuitive shortcut (and it's already used).

For example CRTL+I is logical for change to italic
CRTL + S => save
etc.

But CTRL+I for hide/show searchbar is not logical no ?

Can you tell me what I can put as shortcut ?

As we hide/show it, before to set focus to this line we used ALT+Q (quick focus) so perhaps we can reuse it.
Or ALT+S (for searching)
Or I don't have more idea for the moment.
But we need a shortcut which is not used.

hrouis updated this revision to Diff 3560.Apr 29 2016, 2:15 PM
hrouis edited edge metadata.
mlaurent accepted this revision.Apr 30 2016, 7:18 AM
mlaurent edited edge metadata.

Seems better than shortcut

This revision is now accepted and ready to land.Apr 30 2016, 7:18 AM
mlaurent closed this revision.Mar 21 2018, 8:40 PM