Details
- Reviewers
jjazeix - Group Reviewers
GCompris: Activities - Maniphest Tasks
- T8808: piano_composition, add replace and edit features.
Diff Detail
- Repository
- R2 GCompris
- Lint
Lint Skipped - Unit
Unit Tests Skipped
src/activities/piano_composition/SwitchableOptions.qml | ||
---|---|---|
43 | Hardcoding has been removed. We now assign the nbOptions when we use SwitchableOptions in the activity. |
Commit link: https://cgit.kde.org/gcompris.git/commit/?h=gsoc_aman_piano_activities&id=306dcec1501b10348a5ee455b8e8392381096268
All the improvements as suggested in the comments will be completed in the next commit along with the undo feature.
src/activities/piano_composition/Note.qml | ||
---|---|---|
62 | because the notes whose position are more than 6 on the staff will have ledger lines and in that case the whole note image has to be inverted. However I've added a readonly property variable for this to make it easy to understand for anyone reading the code. | |
119 | -6 is the returned value denoting invalid condition. Since the numbers upto -5 are already occupied, I chose -6 to be the invalid case number. Sure, will create a readonly property for it. |