Don't set explicit spacing on RadioButton/CheckBox
ClosedPublic
Actions

Authored by broulik on May 24 2018, 8:50 AM.

Details

Reviewers

Group Reviewers

Plasma
VDG

Commits

Summary

The appropriate spacing is already determined by the indicator's width

Test Plan

Left and right spacing is consistent now when used in e.g. a FormLayout
Also looks ok in Oxygen and Fusion

Repository

R858 Qt Quick Controls 2: Desktop Style

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.May 24 2018, 8:50 AM

This revision is now accepted and ready to land.May 24 2018, 8:59 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			org.kde.desktop/CheckBox.qml (1 line)
M			org.kde.desktop/RadioButton.qml (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	34786			May 24 2018, 8:45 AM	★	★
Diff 2	34792	ec06b3b	R858:05d7f273eb940363b7e63e5b5f7e7fd1af25a84f	May 24 2018, 9:59 AM	★	★