Differential D13080

Silence -Wformat-truncation warnings
ClosedPublic
Actions

Authored by mglb on May 23 2018, 9:28 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:847b72358d6c: Silence -Wformat-truncation warnings
Summary

Add a few bytes to a small arrays on stack in order to make compiler
happy. Those warnings are invalid in this context (as long as terminal
width and height are not larger than 8-digits-long number).

BUG: 394565

Test Plan
  • Build Konsole with GCC 8 and -Wformat-truncation flag

Expected result: no format-truncation warnings
Actual result: three format-truncation warnings appear

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mglb created this revision.May 23 2018, 9:28 PM
Restricted Application added a project: Konsole. · View Herald TranscriptMay 23 2018, 9:28 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
mglb requested review of this revision.May 23 2018, 9:28 PM
hindenburg accepted this revision.May 23 2018, 11:38 PM
hindenburg added a subscriber: hindenburg.

Thanks

This revision is now accepted and ready to land.May 23 2018, 11:38 PM
Closed by commit R319:847b72358d6c: Silence -Wformat-truncation warnings (authored by mglb, committed by hindenburg). · Explain WhyMay 23 2018, 11:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/Vt102Emulation.cpp (4 lines)

Diff 34763

View Options

src/Vt102Emulation.cpp

Loading...