[Timer applet] Fix double speed countdown & commands run multiple times

Authored by kossebau on May 23 2018, 3:21 PM.



Both the compact and the fullpresentation variants of the applet had
an instance of a timer, and both were connected to the central "running"
flag. So if both variants had been created, there were 2 timers triggering
the decreasing of the seconds, and also firing off the command once done.

Moving the countdown timer (and at the same time also a timer for
delayed saving of the state, which had the same issue) to the central root
item fixes this.

BUG: 381173
FIXED-IN: 5.12.6

Test Plan

Applet still works as before on panel and background pane, now does proper
countdown in both cases.

Diff Detail

R114 Plasma Addons
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.May 23 2018, 3:21 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 23 2018, 3:21 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.May 23 2018, 3:21 PM

Patch is against 5.12 branch. Sadly does not apply cleanly against 5.13 & master, blame me for code brush up since then...

kossebau edited the summary of this revision. (Show Details)May 23 2018, 3:27 PM
davidedmundson accepted this revision.May 23 2018, 3:30 PM
davidedmundson added a subscriber: davidedmundson.


This revision is now accepted and ready to land.May 23 2018, 3:30 PM
This revision was automatically updated to reflect the committed changes.