Don't manipulate foreign windows
ClosedPublic

Authored by broulik on May 23 2018, 2:09 PM.

Details

Test Plan

I noticed that Chrome's window had the property

_KDE_NET_WM_DESKTOP_FILE(UTF8_STRING) = "org.kde.kdialog"

and it uses kdialog --attach for a Save As dialog with proper parent dimming

  • Attached kdialog to another window, it never got its desktop file name forcefully changed to that.
  • Verified apps own windows still get the property set

Diff Detail

Repository
R135 Integration for Qt applications in Plasma
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.May 23 2018, 2:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 23 2018, 2:09 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 23 2018, 2:09 PM
broulik updated this revision to Diff 34712.
  • Remove accidental coding style change
broulik edited the test plan for this revision. (Show Details)May 23 2018, 2:11 PM
davidedmundson accepted this revision.May 23 2018, 4:14 PM
This revision is now accepted and ready to land.May 23 2018, 4:14 PM
graesslin accepted this revision.May 23 2018, 5:48 PM
graesslin added a subscriber: graesslin.

Please as bugfix to 5.12 branch.

This revision was automatically updated to reflect the committed changes.