piano_composition, added rests.
ClosedPublic
Actions

Authored by amankumargupta on May 22 2018, 7:49 PM.

Details

Reviewers

jjazeix

Group Reviewers

GCompris: Improvements

Maniphest Tasks

T8709: piano_composition, add rests.

Summary

The rests of all type have been added: a. Whole b. Half c. Quarter d. Eighth
The code has been refactored a bit to have notes and rests follow the same process of code execution.

Repository

R2 GCompris

Lint

Lint Skipped

Unit

Unit Tests Skipped

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

amankumargupta requested review of this revision.May 22 2018, 7:49 PM

jjazeix added inline comments.

src/activities/piano_composition/SwitchableOptions.qml
42	why 4 is hardcoded?

src/activities/piano_composition/SwitchableOptions.qml
42	because we have 4 types of options: whole, half, quarter, eighth

src/activities/piano_composition/SwitchableOptions.qml
42	Actually yes, you are right. I should not hardcode it. We can have another set of options whose length is not 4 (I saw its need today for adding erase and replace features). I'll give the options array to this file and will do here % options.length. Cause for now, it'll cause conflict in applying the diff and the task I've almost finished. So, I'll update it in the next diff.

This revision is now accepted and ready to land.May 24 2018, 8:48 AM

		Path
M		src/activities/piano_composition/MultipleStaff.qml (88 lines)
M		src/activities/piano_composition/Note.qml (27 lines)
M		src/activities/piano_composition/NoteNotations.js (24 lines)
M		src/activities/piano_composition/Piano_composition.qml (69 lines)
M		src/activities/piano_composition/Staff.qml (31 lines)
A	M	src/activities/piano_composition/SwitchableOptions.qml (63 lines)
M		src/activities/piano_composition/piano_composition.js (8 lines)
A	M	src/activities/piano_composition/resource/eighthRest.svg (59 lines)
A	M	src/activities/piano_composition/resource/quarterRest.svg (59 lines)
A	M	src/activities/piano_composition/resource/wholeRest.svg (59 lines)