Differential D13017

Provide a way to rotate images 90 degrees before passing them on to barcode decoder
ClosedPublic
Actions

Authored by svuorela on May 21 2018, 1:07 PM.

Details

Reviewers
vkrause
Commits
R1003:5c70204a2a92: Provide a way to rotate images 90 degrees before passing them on to barcode…
Summary

We have api to handle rotated pdf417 barcodes

Test Plan

I can get data from some barcodes now.

Diff Detail

Repository
R1003 KItinerary: Travel Reservation handling library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
svuorela created this revision.May 21 2018, 1:07 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 21 2018, 1:07 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
svuorela requested review of this revision.May 21 2018, 1:07 PM
vkrause added a comment.May 21 2018, 1:43 PM

That works, but I think we can make this slightly more elegant: in the normal decodePdf417(), check if width < height, and rotate automatically in that case.

svuorela updated this revision to Diff 34579.May 21 2018, 1:54 PM

Check width/height for rotating rather than having the user do it.

vkrause accepted this revision.May 21 2018, 4:11 PM
This revision is now accepted and ready to land.May 21 2018, 4:11 PM
Closed by commit R1003:5c70204a2a92: Provide a way to rotate images 90 degrees before passing them on to barcode… (authored by svuorela). · Explain WhyMay 21 2018, 6:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/extractorengine.cpp (8 lines)

Diff 34597

View Options

src/extractorengine.cpp

Loading...