Don't return on error conditions, exit instead. It's a child process we
need to finish it
Don't use pam_syslog, there's a comment at the beginning saying it
doesn't work, it seems to kind of work for me but some investigation by
Matthias Gerstner seems to show it's doing funny things with the fds
so don't use it.
Details
Details
Diff Detail
Diff Detail
- Repository
- R107 KWallet PAM Integration
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
it's not pointless, it's "unneeded" since the child process will exit on the "cleanup" goto and then all its resources should be freed anyway by the OS, *but* it is the correct thing to do, the fact that the memory was allocated by the parent process doesn't mean the memory still needs freeing in the child process too, i.e. fork basically "mallocs" the memory again (simplified version of what is happening). Example: at https://paste.kde.org/psqeol0uc