Use QProxyFilterModel to filter debug messages.
ClosedPublic

Authored by knauss on May 20 2018, 4:46 PM.

Details

Summary

As we have a DebugModel we can filter the interessting connections
instead of using tabs.

Diff Detail

Repository
R199 Akonadi Console
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss created this revision.May 20 2018, 4:46 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 20 2018, 4:46 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
knauss requested review of this revision.May 20 2018, 4:46 PM
dvratil accepted this revision.May 21 2018, 6:15 PM

Nice!! Two minor nitpicks, just fix them before pushing. Thanks a lot for working on this, Sandro!

src/debugmodel.cpp
40

const &

src/debugmodel.h
34

This is a bit confusing because what's client's output is server's input :) I'd prefer having values that are more clear, like ServerToClient and ClientToServer, or changing the enum completely from direction to sender.

This revision is now accepted and ready to land.May 21 2018, 6:15 PM
This revision was automatically updated to reflect the committed changes.