setup the mpris interface in c++
Details
Details
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Branch
- move_mpris
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
I am unsure about the added value of this diff. At least, you should fiwx the reported issues. I would really prefer not to add many #ifdef in the c++ code in favor of platform specific qml files.
| src/qml/ElisaMainWindow.qml | ||
|---|---|---|
| 127–147 | By removing this, you also remove the integration with the Windows task bar. I would even say that this is one of the tasks where qml is ideal. You can very easily specialize some files for each platforms without having to add many #ifdef in the c++ code. | |
| 141–149 | What about platforms where you do not have dbus or the mpris2 code ? | |
Comment Actions
At the time of writing this I wasn't aware how Windows works in this regard, and I agree, having the platform specific code in the qml files is the best solution. Maybe I will try to clean it up a bit differently at some point