Reduce the boilerplate needed for commandLineArgs
ClosedPublic

Authored by tcanabrava on May 18 2018, 3:47 PM.

Details

Summary

Use the new initialization syntax plus a initialization vector
to remove the need to call parser->addOption(QCommandLineOption
on every single command line option.

The code now store things in a vector, that is in fact slower
but this should be negligible, and the code is easier to extend
and to read.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcanabrava created this revision.May 18 2018, 3:47 PM
Restricted Application added a project: Konsole. · View Herald TranscriptMay 18 2018, 3:47 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.May 18 2018, 3:47 PM
hindenburg accepted this revision.May 22 2018, 3:07 PM
hindenburg added a subscriber: hindenburg.

Thanks this is much cleaner

This revision is now accepted and ready to land.May 22 2018, 3:07 PM
This revision was automatically updated to reflect the committed changes.