Fix regression with completed jobs being rescheduled erroneously.
ClosedPublic

Authored by TallFurryMan on May 16 2018, 3:40 PM.

Details

Summary

A recent change made a completed job return to evaluation, in order to verify that duplicates were either complete too or needed repeats.
This caused those completed jobs to be considered again for processing after being re-evaluated.
This was an issue in the case option 'Remember Job Progress' was enabled, because Ekos would not run any capture and would stall the Scheduler.
Filtering again on state after evaluating and before considering the next job solves the issue.

Test Plan

Test with .esl "simple_test_no_twilight" with option 'Remember Job Progress' enabled.
Without this change, selected job completes, but stays selected for next observation. Scheduler stalls.
With this change, selected job completes, but is subsequently disregarded by the scheduler, as expected.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
TallFurryMan created this revision.May 16 2018, 3:40 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMay 16 2018, 3:40 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
TallFurryMan requested review of this revision.May 16 2018, 3:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 16 2018, 3:43 PM
This revision was automatically updated to reflect the committed changes.