Differential D12928

Make Apply/Discard settings prompt consistent with rest of settings
ClosedPublic
Actions

Authored by broulik on May 16 2018, 1:12 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Commits
R101:ac133254b761: Make Apply/Discard settings prompt consistent with rest of settings
Summary

When switching between shortcut categories with pending changes, a user would only be given the opportunity to discard them or cancel out and save manually.
This makes it consistent with what System Settings usually offers, a Discard, Apply, and Cancel option

Test Plan

Before


After

  • Apply: applies new shortcut setting and sends it over so it works immediately, then switches categories
  • Discard: discards new shortcut setting, then switches categories
  • Cancel: does nothing. It still switches the current index in the table view but that is an unrelated bug, possibly porting bug or Qt 5 behavior change

Diff Detail

Repository
R101 KHotKeys
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 16 2018, 1:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 16 2018, 1:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 16 2018, 1:12 PM
ngraham accepted this revision.May 16 2018, 3:57 PM
This revision is now accepted and ready to land.May 16 2018, 3:57 PM
Closed by commit R101:ac133254b761: Make Apply/Discard settings prompt consistent with rest of settings (authored by broulik). · Explain WhyMay 22 2018, 12:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcm_hotkeys/kcm_hotkeys.cpp (32 lines)

Diff 34638

View Options

kcm_hotkeys/kcm_hotkeys.cpp

Loading...