Change KmessageBox::detailedError dialog type to KmessageBox::error for a better view.
When the dialog is created the details are hidden. The detail text is not that long that it couldn't be shown directly.
More, the new dialog box could be ::sorry, it changes the caption from "error" to "sorry" and the icon from the red error to the yellow warning
FIXED: [ 383567 ] Details section is empty in 'Do not know which files to compare.' window
BUG: 383567
Simply select ".." in one of the two panels and click "Compare by content"
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I like this change, thanks Davide! I think ::sorry dialog is even better for this scenario but that's a matter of taste :).
Just one minor suggestion: rename "Ugly message dialog on Compare by Content error" with "Fixed ugly message dialog on Compare by Content error" so others will know you haven't introduced anything ugly :)
For my part, my performed tests went alright!
I like this change, thanks Davide! I think ::sorry dialog is even better for this scenario but that's a matter of taste :).
In https://api.kde.org/frameworks/kwidgetsaddons/html/namespaceKMessageBox.html#ac799ff6b0a491b1356981777c99c7551 it says that about KMessageBox::error :
Your program messed up and now it's time to inform the user. To be used for important things like "Sorry, I deleted your hard disk."
[...]
In https://api.kde.org/frameworks/kwidgetsaddons/html/namespaceKMessageBox.html#a02dfebea27d2b3e28199aa543a4d012c it says that about KMessageBox::sorry :
Either your program messed up and asks for understanding or your user did something stupid.
To be used for small problems like "Sorry, I can't find the file you specified."
[...]
So I would use KMessageBox::sorry, as Martin wrote :-)
Thanks for those improvements, Davide!
Just one minor suggestion: rename "Ugly message dialog on Compare by Content error" with "Fixed ugly message dialog on Compare by Content error" so others will know you haven't introduced anything ugly :)
I agree, too :-)
| krusader/krslots.cpp | ||
|---|---|---|
| 176 | Why the puzzle string? And I don't think we need <qt> anymore after Qt3 | |
| krusader/krslots.cpp | ||
|---|---|---|
| 176 | I think this CR is good enough as a bug fix. For the <qt>, KUIT or other refactoring, it should go to a separate CR that updates all the corresponding places in the project. | |
I tried to break as less things as possible. I have a little knowledge of i18n but I think that merging the text will require a new strings translation; from my point of view, translations magically appear when I compile. I can put a comment in the final commit to let others to know that it can be refactored.