Differential D12894

Rename KActivities linking plugin
ClosedPublic
Actions

Authored by broulik on May 15 2018, 9:59 AM.

Details

Reviewers
ivan
ngraham
Group Reviewers
VDG
Commits
R320:8a260b73f478: Rename KActivities linking plugin
Summary

This text is shown in the Services selection of Dolphin and awfully technical compared to the other entries in there.

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik requested review of this revision.May 15 2018, 9:59 AM
broulik created this revision.
ngraham accepted this revision.May 15 2018, 10:47 PM
This revision is now accepted and ready to land.May 15 2018, 10:47 PM
ivan requested changes to this revision.May 15 2018, 11:19 PM

Maybe "Linking files to activities" would be better?

This revision now requires changes to proceed.May 15 2018, 11:19 PM
broulik updated this revision to Diff 34257.May 16 2018, 6:28 AM
  • Use suggested wording
ivan accepted this revision.May 16 2018, 11:33 AM
This revision is now accepted and ready to land.May 16 2018, 11:33 AM
Closed by commit R320:8a260b73f478: Rename KActivities linking plugin (authored by broulik). · Explain WhyMay 16 2018, 11:36 AM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.May 16 2018, 4:26 PM

I liked Kai's original wording better. The other entries in this list are written in the imperative mood, and while the committed version is better than it was before because it's less grammatically awkward, it still doesn't match the rest of the entries. Consider using Kai's original instead.

ivan added a comment.May 16 2018, 6:27 PM

The problem with the original wording is mainly in using singular. It is for linking files to activities. I'm open to suggestions.

ngraham added a comment.May 16 2018, 6:41 PM

"Link file to activities"
"Link files to activities"

?

ivan added a comment.May 17 2018, 9:20 AM

The second one sounds ok

Revision Contents
Changeset List

Diff 34283

View Options

activities/fileitemplugin/kactivitymanagerd_fileitem_linking_plugin.desktop

Loading...