Use default output device when changing global volume
ClosedPublic

Authored by drosca on Apr 1 2016, 3:47 PM.

Details

Summary

Global shortcuts now changes volume of default output device
only, instead of all output devices. Applet icon now displays
volume of default output device only, instead of first output device
in list.

Changing volume with wheel and muting with middle click on applet icon
no longer shows OSD.

Added tooltip subtext for applet showing volume level and name of
default output device.

BUG: 352370
BUG: 357214
BUG: 352727

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca updated this revision to Diff 3064.Apr 1 2016, 3:47 PM
drosca retitled this revision from to Use default output device when changing global volume.
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added a reviewer: Plasma.
drosca added a subscriber: plasma-devel.
sebas accepted this revision.Apr 5 2016, 12:09 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Apr 5 2016, 12:09 PM

changing volume with wheel and muting with middle click on applet icon no longer shows OSD.

Why? This makes it inconsistent with what battery does. Battery does only not show the OSD when the popup is opened as then it's obvious.

Why?

The volume is already indicated by the icon (very roughly though), and now it also shows the percentage in tooltip. So I think the OSD should be displayed only when changing the volume with global shortcuts.

In battery applet, the display brightness is not in icon nor in tooltip which makes it different.

Fair enough... it's also what KMix used to do.

This revision was automatically updated to reflect the committed changes.