Differential D12889

Remove multiple usage of SQL parameter
ClosedPublic
Actions

Authored by mykolak on May 15 2018, 6:54 AM.

Details

Reviewers
mgallien
Group Reviewers
Elisa
Commits
R255:dd84041481ee: Remove multiple usage of SQL parameter
Summary

Patch removes multiple usage of SQL parameter in query. When parameter is used twice, I've got an
QSqlError("", "Parameter count mismatch", "")
in terminal and problem with albums and artists folders in UI.

I'm not sure this is Elisa bug, though, haven't found explicit statement that parameter should be used only once in either Qt or SQLite docs.

BUG: 394259

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mykolak requested review of this revision.May 15 2018, 6:54 AM
mykolak created this revision.
mgallien accepted this revision.May 16 2018, 7:53 PM
This revision is now accepted and ready to land.May 16 2018, 7:53 PM
astippich added a subscriber: astippich.May 21 2018, 1:27 PM

Shall I land this for you?

mykolak added a comment.May 23 2018, 2:34 PM
In D12889#265937, @astippich wrote:

Shall I land this for you?

Should I do something?

mykolak added a comment.May 24 2018, 3:30 PM
In D12889#265937, @astippich wrote:

Shall I land this for you?

Could you do that, please? I'm not able to do that.

Closed by commit R255:dd84041481ee: Remove multiple usage of SQL parameter (authored by mykolak, committed by astippich). · Explain WhyMay 24 2018, 6:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/databaseinterface.cpp (4 lines)

Diff 34835

View Options

src/databaseinterface.cpp

Loading...