Remove the internal file navigation from the global drawer
ClosedPublic
Actions

Authored by apol on May 14 2018, 11:48 PM.

Details

Reviewers

mart
aacid

Group Reviewers

Okular

Commits

Summary

Instead include an "open" item.

Test Plan

opened a file

Repository

R223 Okular

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: okular-devel. · View Herald Transcript

apol requested review of this revision.May 14 2018, 11:48 PM

core/document.cpp
2362 ↗	(On Diff #34168)	I don't think it's a good idea changing the behaviour, can't you fix the mobile app to do the right thing?

core/document.cpp
2362 ↗	(On Diff #34168)	Sure, I did it because it feels like broken API. It just complains and doesn't do anything when you openDocument twice. Will move into the QtQuick side.

Don't add logic in core/ just in case

apol marked an inline comment as done.May 16 2018, 3:04 PM

mobile/app/package/contents/ui/main.qml
33	That path is WHAAAT

Remove hardcoded path

This revision is now accepted and ready to land.May 17 2018, 2:56 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		mobile/app/app.qrc (1 line)
D	M	mobile/app/package/contents/ui/Documents.qml (106 lines)
M		mobile/app/package/contents/ui/Thumbnails.qml (2 lines)
M		mobile/app/package/contents/ui/main.qml (37 lines)
M		mobile/components/documentitem.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	34168	5931c0d		May 14 2018, 11:48 PM	★	★
Diff 2	34297	5931c0d	Don't add logic in core/ just in case	May 16 2018, 3:03 PM	★	★
Diff 3	34335	5931c0d	Remove hardcoded path	May 16 2018, 11:04 PM	★	★
Diff 4	34371	93645d1	R223:600e72100b13635fb46216b7c11dcb498149baf1	May 17 2018, 2:56 PM	★	★