Differential D12874

Piano_composition, make note-type options switchable on clicks, indentation corrections and renamed staff2 to multipleStaff.
ClosedPublic
Actions

Authored by amankumargupta on May 14 2018, 12:22 PM.

Details

Reviewers
jjazeix
Group Reviewers
GCompris: Improvements
Maniphest Tasks
T8691: Piano_composition, condense all the note-type options in one and make them switchable on clicks.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
Restricted Application added a project: KDE Edu. · View Herald TranscriptMay 14 2018, 12:22 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
amankumargupta added inline comments.May 14 2018, 12:24 PM
src/activities/piano_composition/Piano_composition.qml
195

This is needed no more after refactoring.

203 ↗(On Diff #34133)

These two variable replaces the use of onlyNote, which was removed above, else the refactoring wouldn't have been possible.

jjazeix added a subscriber: jjazeix.May 14 2018, 3:50 PM
jjazeix added inline comments.
src/activities/piano_composition/Piano_composition.qml
209 ↗(On Diff #34133)

why setting 0 and not just setting "visible: bar.level == 1 || bar.level == 2 ? false : true" here directly?

252 ↗(On Diff #34133)

I'm not sure why I used staff2, but it can probably be renamed :)

amankumargupta marked 2 inline comments as done.May 14 2018, 5:01 PM
amankumargupta added inline comments.
src/activities/piano_composition/Piano_composition.qml
209 ↗(On Diff #34133)

ahh, that's very silly of me :p Thanks! Corrected in the latest diff.

252 ↗(On Diff #34133)

Renamed to multipleStaff

amankumargupta updated this revision to Diff 34154.May 14 2018, 5:02 PM
amankumargupta marked 2 inline comments as done.

Renamed staff2 to multipleStaff.

amankumargupta added inline comments.May 14 2018, 5:04 PM
src/activities/piano_composition/Piano_composition.qml
203

Will make these 2 variables readonly before committing. It completely got off my mind while creating the diff.

amankumargupta updated this revision to Diff 34224.May 15 2018, 7:42 PM
amankumargupta retitled this revision from Piano_composition, add an indicator to highlight the currently selected note-type, minor refactoring and indentation corrections. to Piano_composition, make note-type options switchable on clicks, indentation corrections and renamed staff2 to multipleStaff..
amankumargupta edited the summary of this revision. (Show Details)
jjazeix accepted this revision.May 16 2018, 6:45 AM
This revision is now accepted and ready to land.May 16 2018, 6:45 AM

Revision Contents
Changeset List

Diff 34154

View Options

src/activities/piano_composition/MelodyList.qml

Loading...
View Options

src/activities/piano_composition/Piano_composition.qml

Loading...
View Options

src/activities/piano_composition/piano_composition.js

Loading...