[SourcesModel] Check changed file name before reloading configuration
ClosedPublic

Authored by broulik on May 14 2018, 11:12 AM.

Details

Summary

Avoid needlessly reloading configuration if something completely unrelated, such as plasma appletsrc, changed.

Test Plan
  • Disabled a runner, codepath was executed and runner was no longer queried. Enabled a runner, it was queried again.
  • No longer needlessly reparses krunnerrc on plasmashell startup

Diff Detail

Repository
R112 Milou
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.May 14 2018, 11:12 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 14 2018, 11:12 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 14 2018, 11:12 AM
apol added a subscriber: apol.May 14 2018, 12:15 PM

It doesn't look like other files are being added to the KDirWatch, no?

KDirWatch is a singleton and when this is used from within plasmashell (e.g. Kickoff's search model) it will cause changes as Units adds watchers on plasma configs

davidedmundson accepted this revision.May 14 2018, 2:00 PM
This revision is now accepted and ready to land.May 14 2018, 2:00 PM
This revision was automatically updated to reflect the committed changes.