Differential D12858

[KCharSelect] Fix table cell size
ClosedPublic
Actions

Authored by cfeck on May 14 2018, 1:10 AM.

Details

Reviewers
rkflx
Group Reviewers
Frameworks
Commits
R236:43d23824a94c: [KCharSelect] Fix table cell size with Qt 5.11
Summary

Qt 5.11 now respects minimumSectionSize (QTBUG-68239).

Without this property set, the table cells end up larger than requested.

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cfeck created this revision.May 14 2018, 1:10 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 14 2018, 1:10 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
cfeck requested review of this revision.May 14 2018, 1:10 AM
elvisangelaccio added a subscriber: elvisangelaccio.May 15 2018, 8:16 PM

+1, tested with Qt 5.11 RC1.

rkflx added a subscriber: rkflx.May 20 2018, 6:17 AM

Not sure whether that's material for this patch, but for me the vertical spacing is still a bit off, i.e. the boxes are still not square as before:

Qt 5.10:

Qt 5.11:

Qt 5.11 (patch applied):

(Spinbox issue already reported by @cfeck in https://bugreports.qt.io/browse/QTBUG-68238…)

cfeck updated this revision to Diff 34516.May 20 2018, 11:54 AM
cfeck retitled this revision from [KCharSelect] Fix table cell width to [KCharSelect] Fix table cell size.
cfeck edited the summary of this revision. (Show Details)

Also limit cell height.

rkflx accepted this revision.May 20 2018, 8:49 PM

Thanks, works great now!

This revision is now accepted and ready to land.May 20 2018, 8:49 PM
Closed by commit R236:43d23824a94c: [KCharSelect] Fix table cell size with Qt 5.11 (authored by cfeck). · Explain WhyMay 22 2018, 2:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kcharselect.cpp (2 lines)

Diff 34649

View Options

src/kcharselect.cpp

Loading...