Differential D12851

Change preview text background color to match with default combobox background color
Needs RevisionPublic
Actions

Authored by progwolff on May 13 2018, 11:25 AM.

Details

Reviewers
mart
abetts
ngraham
Summary

The default combobox background color is white (QPalette::Base / Kirigami.Theme.View),
preview comboboxes were gray (QPalette::Window / Kirigami.Theme.Window)

Test Plan

Diff Detail

Repository
R119 Plasma Desktop
Branch
fonts_kcm_comboboxes (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
progwolff created this revision.May 13 2018, 11:25 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 13 2018, 11:25 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
progwolff requested review of this revision.May 13 2018, 11:25 AM
progwolff edited the test plan for this revision. (Show Details)May 13 2018, 11:25 AM
ngraham accepted this revision.May 13 2018, 10:44 PM
This revision is now accepted and ready to land.May 13 2018, 10:44 PM
rkflx added a subscriber: rkflx.Jun 6 2018, 9:48 PM

Anything left to be done here? I guess this should land on the Plasma/5.13 branch, since it's still broken there (I almost wrote a patch…).

Patch LGTM, but there's still an issue (but not sure if intentional or not): The hover effect does not apply to the preview image, it stays white instead of getting a blue background.

progwolff added a comment.Jun 7 2018, 6:28 AM

Sorry for the delay...
I planned to land this together with D12849 and D12925.

It will take me two weeks or so until I can continue working on this. I need to finish my master thesis first...

If you want to have this on the 5.13 branch, please feel free to land it.

rkflx added a comment.Jun 7 2018, 6:42 AM
In D12851#275112, @progwolff wrote:

Sorry for the delay...

No problem ;)

If you want to have this on the 5.13 branch, please feel free to land it.

I guess that's something for Plasma to decide.

ngraham added a comment.Jan 2 2019, 4:10 AM

I vote for landing this now. It's independent of other changes and improves the legibility. Plasma folks?

ngraham requested changes to this revision.Dec 5 2019, 9:37 PM

Hmm, this doesn't look so great all on its own:

I think the graphical representations of the various anti-aliasing styles would also need to change their background colors.

Also the patch needs to be rebased on current master.

This revision now requires changes to proceed.Dec 5 2019, 9:37 PM

Revision Contents
Changeset List

Diff 34067

View Options

kcms/fonts/package/contents/ui/main.qml

Loading...
View Options

kcms/fonts/previewimageprovider.cpp

Loading...