Differential D12850

Use the right API for iterating a directory
ClosedPublic
Actions

Authored by apol on May 13 2018, 11:19 AM.

Details

Reviewers
None
Group Reviewers
Sysadmin
Commits
R857:ed0e15973a54: Use the right API for iterating a directory
Summary

Use DirEntries instead of constructing paths and request data randomly
makes the script a bit faster and the code easier to read.

Test Plan

Works here, didn't work in the CI, I don't understand why.
https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20FreeBSDQt5.10/6/

Diff Detail

Repository
R857 CI System Tooling
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol requested review of this revision.May 13 2018, 11:19 AM
apol created this revision.
apol updated this revision to Diff 34068.May 13 2018, 11:35 AM

actually fix execution

This revision was not accepted when it landed; it landed in state Needs Review.May 13 2018, 5:45 PM
Closed by commit R857:ed0e15973a54: Use the right API for iterating a directory (authored by apol). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhelpers/helperslib/Buildable.py (17 lines)

Diff 34074

View Options

helpers/helperslib/Buildable.py

Loading...