Differential D12840

Wrap the footer content in a container class div
AcceptedPublic
Actions

Authored by richardbowen on May 12 2018, 11:46 PM.

Details

Reviewers
jriddell
bcooksley
Summary

Before:

After:

Diff Detail

Repository
R954 Planet (Blogosphere) for KDE (customised Rawdog)
Branch
footer-padding (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
richardbowen requested review of this revision.May 12 2018, 11:46 PM
richardbowen created this revision.
bcooksley added a comment.May 13 2018, 12:04 AM

Can you attach a screenshot showing the differences?

richardbowen edited the summary of this revision. (Show Details)May 13 2018, 1:09 AM
richardbowen added a comment.May 13 2018, 1:12 AM
In D12840#261568, @bcooksley wrote:

Can you attach a screenshot showing the differences?

Done.

richardbowen retitled this revision from Wrap the footer content in a container div for margin padding to Wrap the footer content in a container class div for left and right margin padding.May 13 2018, 1:18 AM
richardbowen retitled this revision from Wrap the footer content in a container class div for left and right margin padding to Wrap the footer content in a container class div.
bcooksley accepted this revision.May 13 2018, 1:22 AM

Thanks, this can go in, although the config file changes look like they're unrelated?

This revision is now accepted and ready to land.May 13 2018, 1:22 AM
richardbowen added a comment.EditedMay 15 2018, 11:59 PM

I only made changes to planetkde/planet_template and added it to staging (git add planetkde/planet_template), it seems arc diff did the rest. The changes made to the config are actually good though.

bcooksley added a comment.May 16 2018, 10:28 AM

The changes to the config file probably came from when you ran rawdog to test the template changes.
They can go in, but please separate them into a different commit.

@jriddell can you please review/approve?

Revision Contents
Changeset List

PathPackages
Mplanetkde/config (4 lines)
Mplanetkde/planet_template (6 lines)

Diff 34040

View Options

planetkde/config

Loading...
View Options

planetkde/planet_template

Loading...