This is just an initial review to gather feedback. It should be
the first building block to allow itinerary to work also when creating
events without reservation files attached.
Details
Details
Compiles
Diff Detail
Diff Detail
- Repository
- R1007 Itinerary - Travel Assistance Application
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
There's almost nothing done yet mainly because I want to gather feedback first on what the approach should be (to avoid doing work that won't be useful).
For example:
- how should non-reservations like TouristAttraction handled?
- Is this the right design (the reservations come from outside the clsss)
- Should we create an entirely new class to create reservations from scratch?
Comment Actions
I think this is the right approach, just the argument needs to be a QVariant, to handle non-reservation types and to not "slice off" Reservation sub-class properties.