QtWebEngine can be newer than the rest of Qt (e.g., on Fedora 27).
This fixes the version check in WebView::savePageAs to use a macro
defined in config.h.cmake based on the version of QtWebEngineWidgets
rather than relying on QT_VERSION, which is the version of QtCore.
CCBUG: 391300
Fedora 27 build (of the original revision): https://koji.fedoraproject.org/koji/buildinfo?buildID=1081337
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
This should be done for all QtWebEngine checks (5.10, 5.11) and should be in config.h with #cmakedefine01 so it can be used as #if HAVE_QTWEBENGINE_5_10
Also, all the existing macros in config.h.cmake are #cmakedefine, not #cmakedefine01, so are you sure you want the latter even though it would be inconsistent?
Yes, the other ones were ported from qmake, but new defines should use cmakedefine01 as that will also produce warning when forgetting including config.h header, instead of just silently ignoring it.
Wouldn't it make sense to port the existing PORTABLE_BUILD and DISABLE_DBUS defines too, then? But that's material for a separate commit in any case.
This version now uses #cmakedefine01 as requested.
I can easily add a macro for 5.11 if you want, but would not be used anywhere on the Falkon/3.0 branch against which I did the change.