Workaround for binding loop in Material Theme
Needs ReviewPublic

Authored by Dax on May 11 2018, 10:12 AM.
This revision needs review, but there are no reviewers specified.



This patch adds a workaround for Material theme: the highlightColor property causes a binding loop thats makes a Kirigami based application to crash.
Instead of initialize the property directly, I have initialized it when Component.onCompleted is called

Tested with Qt 5.10.1 on Android

Diff Detail

R169 Kirigami
Lint Skipped
Unit Tests Skipped
Dax created this revision.May 11 2018, 10:12 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptMay 11 2018, 10:12 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
Dax requested review of this revision.May 11 2018, 10:12 AM
apol added a subscriber: apol.May 12 2018, 11:25 AM

I've seen this warning, never seen it crash.

This looks like a workaround though. Do you know why it's happening? Why's theme.Material.accent changing?

mart added a subscriber: mart.May 14 2018, 9:04 AM

this would break the binding loop, and things should be able to dynamically change color, so the proper cause should be found