Differential D12810

Do not require Frameworks 5.45
ClosedPublic
Actions

Authored by nicolasfella on May 10 2018, 4:38 PM.

Details

Reviewers
apol
Commits
R224:68d0c5d14326: Do not require Frameworks 5.45
Summary

Ifdef for old KF5 as discussed in D11684.

Test Plan

Can still use feature when above 5.45

Diff Detail

Repository
R224 KDE Connect
Branch
ifdef
Lint
No Linters Available
Unit
No Unit Test Coverage
nicolasfella created this revision.May 10 2018, 4:38 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptMay 10 2018, 4:38 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.May 10 2018, 4:38 PM
apol accepted this revision.May 10 2018, 5:06 PM
This revision is now accepted and ready to land.May 10 2018, 5:06 PM
Closed by commit R224:68d0c5d14326: Do not require Frameworks 5.45 (authored by nicolasfella). · Explain WhyMay 10 2018, 5:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Mkcm/kcm.cpp (5 lines)
Mplugins/runcommand/runcommandplugin.cpp (7 lines)

Diff 33954

View Options

CMakeLists.txt

Loading...
View Options

kcm/kcm.cpp

Loading...
View Options

plugins/runcommand/runcommandplugin.cpp

Loading...