Differential D12806

CoreFileTest
ClosedPublic
Actions

Authored by himanshuvishwakarma on May 10 2018, 2:04 PM.

Details

Reviewers
jjazeix
Summary

A unit test of class File in core library

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
Restricted Application added a project: KDE Edu. · View Herald TranscriptMay 10 2018, 2:04 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
himanshuvishwakarma requested review of this revision.May 10 2018, 2:04 PM
jjazeix added a comment.May 10 2018, 3:45 PM

Don't forget to also test the sanitizeUrl method.

tests/core/FileTest.cpp
47

I'm not sure the file exists just by settings its name. You should at least write in it before

51

you should remove the created files at the end of the test, to be sure it does not impact the next tests and each are independant

58

fileContent

61

The file is missing a filename

63

can you also check the content of the error here?

This revision is now accepted and ready to land.Aug 26 2018, 7:45 PM
jjazeix closed this revision.Aug 26 2018, 7:45 PM

Revision Contents
Changeset List

PathPackages
Mtests/core/CMakeLists.txt (1 line)
AMtests/core/FileTest.cpp (71 lines)

Diff 33946

View Options

tests/core/CMakeLists.txt

Loading...
View Options

tests/core/FileTest.cpp

Loading...