Differential D12793

Reenable navigation inside QtDocumentation
ClosedPublic
Actions

Authored by croick on May 9 2018, 10:37 PM.

Details

Reviewers

apol

Commits

R32:4e02a129bfbb: Reenable navigation inside QtDocumentation

Summary

updating a web page using QtWebEnginePage::load() in StandardDocumentationViewdoes not seem to work for the Qt documentation pages and only using a new widget does the job
adding a url to the documentation history when showing a page now is the default, which reverts 3f7a93af06ce
requires similar changes in kdev-php

BUG 393445

Test Plan

navigate in Qt documentation between different classes (QString->QChar for example)
navigate in manpages
navigate in PHP documentation (with changes applied to kdev-php)

Diff Detail

Repository

R32 KDevelop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

croick created this revision.May 9 2018, 10:37 PM

Restricted Application added a project: KDevelop. · View Herald TranscriptMay 9 2018, 10:37 PM

Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript

croick requested review of this revision.May 9 2018, 10:37 PM

LGTM. If that's what it takes...

I can't remember what's the story behind addHistory.

So can this be accepted?
And is not adding group reviewers still the preferred policy?

And yes, you should have added #kdevelop as reviewer.

This revision is now accepted and ready to land.Jun 18 2018, 11:06 AM

In D12793#279450, @apol wrote:

And yes, you should have added #kdevelop as reviewer.

Ok, there was just that mail some time ago, telling us not to add group reviewers any longer, since subscribers (kdevelop-devel) are already added automatically.
I realize that this is not really working out.

Thanks for your review, I will also make the changes to kdev-php.

Closed by commit R32:4e02a129bfbb: Reenable navigation inside QtDocumentation (authored by croick). · Explain WhyJun 18 2018, 8:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kdevplatform/documentation/documentationview.h (4 lines)
M			kdevplatform/documentation/documentationview.cpp (13 lines)
M			kdevplatform/interfaces/idocumentationprovider.h (3 lines)
M			plugins/cmake/cmakedocumentation.h (3 lines)
M			plugins/manpage/manpageplugin.h (3 lines)
M			plugins/qthelp/qthelpdocumentation.cpp (2 lines)
M			plugins/qthelp/qthelpproviderabstract.h (2 lines)
M			plugins/qthelp/qthelpproviderabstract.cpp (5 lines)