move header bar and control manager to c++
ClosedPublic
Actions

Authored by astippich on May 9 2018, 7:20 PM.

Details

Reviewers

mgallien

Commits

Summary

next step of moving more classes to c++

Test Plan

headerbar still shows correct data, player controls still work

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

astippich requested review of this revision.May 9 2018, 7:20 PM

astippich created this revision.

src/qml/ElisaMainWindow.qml
139–144	Please keep that. As far as I know, it is needed to open Elisa from mpris2 protocol.

Looks good except one issue. Please have a look at it.

This revision now requires changes to proceed.May 16 2018, 6:49 PM

This revision is now accepted and ready to land.May 16 2018, 7:48 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/elisaapplication.h (22 lines)
M			src/elisaapplication.cpp (57 lines)
M			src/qml/ContentView.qml (6 lines)
M			src/qml/ElisaMainWindow.qml (69 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	33905	937c8aa		May 9 2018, 7:20 PM	★	★
Diff 2	34319	937c8aa	- bring back raise player	May 16 2018, 7:34 PM	★	★
Diff 3	34324	cc0d45e	- rebase on master	May 16 2018, 8:13 PM	★	★
Diff 4	34326	4f6142b	R255:9b44b1df3e88376428f8cabbe3cca8b61a14a5f3	May 16 2018, 8:13 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
c13438b10ac4	0a4ff1d8d224	20d5fb177b66	Alexander Stippich	bring back raise player	May 16 2018, 7:23 PM
20d5fb177b66	222a53898fac	cc0d45ec5d92	Alexander Stippich	move header bar and control manager to c++ (Show More…)	May 9 2018, 6:59 PM