CoreDirectoryTest
ClosedPublic

Authored by himanshuvishwakarma on May 9 2018, 4:51 PM.

Details

Reviewers
jjazeix
Summary

An auto unit test is added to class Directory in the core library

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
Restricted Application added a project: KDE Edu. · View Herald TranscriptMay 9 2018, 4:51 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
himanshuvishwakarma requested review of this revision.May 9 2018, 4:51 PM
jjazeix requested changes to this revision.May 9 2018, 5:13 PM
jjazeix added inline comments.
tests/core/DirectoryTest.cpp
41

directory

46

you can add a QCOMPARE to be sure the folder has been created

49

It counts

65

I would still remove the folder at the end of the function too

This revision now requires changes to proceed.May 9 2018, 5:13 PM
jjazeix accepted this revision.May 10 2018, 1:44 PM

Good for me, you can commit it on the master branch.

Thank you

tests/core/DirectoryTest.cpp
49

I think you can directly Q_COMPARE on the mkpath that returns true if the folder has been created

This revision is now accepted and ready to land.May 10 2018, 1:44 PM
jjazeix added inline comments.May 10 2018, 3:35 PM
tests/core/DirectoryTest.cpp
49

even QVERIFY seems better to not continue if the folder hasn't been created

jjazeix closed this revision.Jun 3 2018, 10:23 AM