CoreDirectoryTest
ClosedPublic
Actions

Authored by himanshuvishwakarma on May 9 2018, 4:51 PM.

Details

Reviewers

jjazeix

Summary

An auto unit test is added to class Directory in the core library

Repository

R2 GCompris

Lint

Lint Skipped

Unit

Unit Tests Skipped

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

jjazeix requested changes to this revision.May 9 2018, 5:13 PM

jjazeix added inline comments.

tests/core/DirectoryTest.cpp
42	directory
47	you can add a QCOMPARE to be sure the folder has been created
50	It counts
66	I would still remove the folder at the end of the function too

This revision now requires changes to proceed.May 9 2018, 5:13 PM

Good for me, you can commit it on the master branch.

Thank you

tests/core/DirectoryTest.cpp
48	I think you can directly Q_COMPARE on the mkpath that returns true if the folder has been created

This revision is now accepted and ready to land.May 10 2018, 1:44 PM

tests/core/DirectoryTest.cpp
48	even QVERIFY seems better to not continue if the folder hasn't been created

			Path	Packages
M			tests/core/CMakeLists.txt (1 line)
A	M		tests/core/DirectoryTest.cpp (74 lines)