Fixed access to current slideshow image using correct field in action_open
ClosedPublic

Authored by odeda on May 9 2018, 9:32 AM.

Details

Summary

With slideshow desktop wallpaper plugin, selecting "Open wallpaper Image" from RMB does nothing. It looks like the action_open method called by the RMB menu action is using an old field that no longer exists.

The patch updates the code to use the correct field.

BUG: 394035

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
odeda created this revision.May 9 2018, 9:32 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 9 2018, 9:32 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
odeda requested review of this revision.May 9 2018, 9:32 AM
odeda added a reviewer: Plasma: Workspaces.
ngraham added a subscriber: ngraham.May 9 2018, 1:59 PM

Thanks for the patch! Please see https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

  • Describe the change in the title
  • Mention the bug in the Summary section, like this: BUG: 394035
odeda retitled this revision from Fix for KDE bug 394035 to Fixed access to current slideshow image using correct field in action_open.May 9 2018, 3:37 PM
odeda edited the summary of this revision. (Show Details)
odeda added a comment.May 9 2018, 3:40 PM

Thanks for the notes. I've followed the instructions in https://community.kde.org/Infrastructure/Github_Mirror , though I didn't follow the link to the Phabricator page you referred to - it might have been a good idea to stress the importance of reading that page a bit more :-)

Thanks for the notes. I've followed the instructions in https://community.kde.org/Infrastructure/Github_Mirror , though I didn't follow the link to the Phabricator page you referred to - it might have been a good idea to stress the importance of reading that page a bit more :-)

Thanks for the heads-up; I'll edit that page!

ngraham accepted this revision.May 9 2018, 8:40 PM

Can confirm both the issue and that this patch fixes it. Thanks! Any objections from other Plasma folks?

This revision is now accepted and ready to land.May 9 2018, 8:40 PM
broulik accepted this revision.May 14 2018, 7:37 AM
broulik added a subscriber: broulik.

Works fine. Thanks!

@odeda, can you provide your email address so that we can land this with proper authorship information? Thanks!

odeda added a comment.May 15 2018, 4:54 AM

Thanks!

My email address is oded@geek.co.il

This revision was automatically updated to reflect the committed changes.