Differential D12775

Always set applet title, even when label is disabled
ClosedPublic
Actions

Authored by hein on May 9 2018, 8:27 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R119:28dc6b88538e: Always set applet title, even when label is disabled
Summary

Except when we're a containment.

This way Folder View applets always have a nice tab title in
the grouping applet.

BUG:394007

Diff Detail

Repository
R119 Plasma Desktop
Branch
Plasma/5.12
Lint
No Linters Available
Unit
No Unit Test Coverage
hein created this revision.May 9 2018, 8:27 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 9 2018, 8:27 AM
hein requested review of this revision.May 9 2018, 8:27 AM
hein updated this revision to Diff 33871.May 9 2018, 8:34 AM

Fix logic error.

mart accepted this revision.May 11 2018, 8:48 AM
This revision is now accepted and ready to land.May 11 2018, 8:48 AM
Closed by commit R119:28dc6b88538e: Always set applet title, even when label is disabled (authored by hein). · Explain WhyMay 11 2018, 8:51 AM
This revision was automatically updated to reflect the committed changes.
broulik added a subscriber: broulik.May 14 2018, 7:40 AM
broulik added inline comments.
containments/desktop/package/contents/ui/FolderViewLayer.qml
85

Except when we're a containment.

Isn't a when: !isContainment nicer, then? (Just asking, no need to change it)

Revision Contents
Changeset List

Diff 33871

View Options

containments/desktop/package/contents/ui/FolderViewLayer.qml

Loading...